Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use the shared _getGridEventLocation method #7452

Merged
merged 2 commits into from
May 27, 2024

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented May 27, 2024

Description

Refactor instances of:

const path = e.composedPath();
const cell = path[path.indexOf(this.$.table) - 3];

in grid and grid-pro to instead use the shared _getGridEventLocation helper.

Type of change

Refactor

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we could mark _getGridEventLocation as protected.

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tomivirkki tomivirkki merged commit c57bc19 into main May 27, 2024
9 checks passed
@tomivirkki tomivirkki deleted the refactor/grid/event-location branch May 27, 2024 12:51
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants